LIBDRUM-972. Remove ETD Loader MARC and CSV functionality#258
Merged
dsteelma-umd merged 2 commits intoumd-lib:feature/LIBDRUM-956from May 30, 2025
Merged
Conversation
Removed the "etd2marc-mail" and "etd2marc-transfer" scripts because based on a May 29, 2025 discussion with Ben Wallberg in the "Dspace" WebEx channel, this is legacy functionality that is no longer needed. Also removed the "drum.etdloader.transfermarc" property, which is no longer needed from the "load-etd-nightly" script, and the "local.cfg.EXAMPLE". Removing these scripts at this time because the use of the "dspace dprop" command in the "load-etd-nightly" Bash script was failing in Kubernetes because the logs from the console were being included in the output returned to the "transfermarc" variable, causing the script to fail. https://umd-dit.atlassian.net/browse/LIBDRUM-972
Removed the functionality to create MARC and CSV files from the EtdLoader class and related scripts. The MARC functionality is definitely legacy, and was removed based on a May 29, 2025 conversation with Ben Wallberg in the "DSpace" WebEx channel. The CSV functionality was removed because it is not clear that is used used (it is not absolutely certain that this is legacy functionality, but is definitely suspected to be). Removed the "etd2marc.xsl" file, because it is presumably no longer needed. Removed the command-line arguments related to the MARC and CSV files from the "load-etd" and "load-etd-nightly" scripts, because they are no longer needed. https://umd-dit.atlassian.net/browse/LIBDRUM-972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EtdLoader class had functionality to create MARC-formatted and CSV-formatted records from the loaded files in the “/dspace/proquest/marc” and “/dspace/proquest/csv”. The MARC-formatted record functionality is definitely legacy functionality, and so was removed. It is not completely certain that the CSV-formatted record functionality is legacy functionality, but there does not appear to be any way to retrieve the files other than by directly accessing the container, so it seems unlikely that it is in use. The history of this functionality is not complete, but both the MARC and CSV functionality exist in the earliest versions of the EtdLoader class available in Git, so since the MARC functionality is legacy, the CSV functionality is likely legacy as well.
Removed the following files as they are no longer needed:
Removed functionality related to creating/transferring MARC-formatted and CSV-formatted records from the following files:
https://umd-dit.atlassian.net/browse/LIBDRUM-972